Address warning message in the CI pipelines #942
Conversation
Upgrade default Node.js version to 16 Resolves a warning about Node.js 12 in the build action by upgrading the default Node.js version to 16 in the Ubuntu image. Changes to be committed: modified: .github/workflows/pull-request.yaml
recena
changed the title
recena
changed the title
|
@atrendafilov In this PR you are updating one pipeline but there are three pipelines. Is there any reason not to update the other? |
.github/workflows/pull-request.yaml
Outdated
| @@ -12,6 +12,9 @@ jobs: | |||
| CI_TOOLS_URL: https://github.com/samuelattwood/partner-charts-ci/releases/latest/download/partner-charts-ci-linux-amd64 | |||
|
|
|||
| steps: | |||
| - uses: actions/setup-node@v2 | |||
| with: | |||
| node-version: '16.x' | |||
There was a problem hiding this comment.
version 16 is sufficient enough and I didn't want to make a huge leap in versions.
There was a problem hiding this comment.
Node 16 is EOL. https://endoflife.date/nodejs
.github/workflows/pull-request.yaml
Outdated
| @@ -12,6 +12,9 @@ jobs: | |||
| CI_TOOLS_URL: https://github.com/samuelattwood/partner-charts-ci/releases/latest/download/partner-charts-ci-linux-amd64 | |||
|
|
|||
| steps: | |||
| - uses: actions/setup-node@v2 | |||
There was a problem hiding this comment.
Why not the latest version?
There was a problem hiding this comment.
same as the above comment about the versions
There was a problem hiding this comment.
I don't see the value of not using the latest version of the official Github Actions.
.github/workflows/pull-request.yaml
Outdated
| @@ -12,6 +12,9 @@ jobs: | |||
| CI_TOOLS_URL: https://github.com/samuelattwood/partner-charts-ci/releases/latest/download/partner-charts-ci-linux-amd64 | |||
|
|
|||
| steps: | |||
| - uses: actions/setup-node@v2 | |||
| with: | |||
| node-version: '16.x' | |||
| - uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
I think the fix is to update this action to the latest version.
There was a problem hiding this comment.
I'm almost sure this fix the warning message. More references actions/checkout#1047 (comment)
There was a problem hiding this comment.
actions/checkout@v2 uses Node12.
There was a problem hiding this comment.
This could be a possible fix, but I'm not familiar with the reason behind the use of actions/checkout@v2 in this pipeline, so just to be on the save side I have opted out for this solution.
There was a problem hiding this comment.
@atrendafilov This is the fix according to the documentation and references. In fact, we don't need to add a new step.
Because in the other pipelines we use |
|
Merging to avoid conflicts. |
Issue
Github CI pipelines action is completed successfully, but with warning about outdated Node.js version
Solution
Upgrade default Node.js version in the Ubuntu image from 12 to 16
Testing done
Successfully tested
Fix #939